indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1240464433
##########
format/FlightSql.proto:
##########
@@ -1842,6 +1842,94 @@ message ActionCancelQueryResult {
CancelResult result = 1;
}
+/*
+ * Request message for the "Close Session" action.
+ */
+message ActionCloseSessionRequest {
Review Comment:
> I'm referring to the options themselves; I thought the original proposal
was that servers should also support sending options as arbitrary headers,
since the existing JDBC driver does that.
At least internally we're looking at moving a bunch of things off of being
sent as headers and over to session options [for robustness, tidiness, header
limits, etc.]. For backwards compatibility internally as well as in the wild
I'm inclined to pursue making the JDBC and ODBC drivers detect the Session
Option doAction verbs and use them if present and only fall back to headers if
the verbs are absent. (Relatedly, it might be useful to have the doAction
listing populated dynamically or overridden by the app's client subclass as the
discrepancy between the listing and what Actions do and do not return a not
implemented status message is a bit confusing for this and other purposes...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
