alamb commented on PR #6722: URL: https://github.com/apache/arrow-datafusion/pull/6722#issuecomment-1610183346
> ideally yes. but I think upstream will be resisting, saying .contains method is enough. FWIW the upstream request is here: https://github.com/apache/arrow-rs/issues/3199 > Basically this wrapper should do the trick I tried that and sadly it gave me this error: ``` cd /Users/alamb/Software/arrow-datafusion2/ && RUST_BACKTRACE=1 CARGO_TARGET_DIR=/Users/alamb/Software/target-df2 cargo test --test sqllogictests Compiling datafusion-common v27.0.0 (/Users/alamb/Software/arrow-datafusion2/datafusion/common) error[E0308]: mismatched types --> datafusion/common/src/dfschema.rs:743:24 | 743 | DFSchema::from(self).equivalent_names_and_types(&DFSchema::from(other)) | -------------- ^^^^ expected `DFSchema`, found `&Schema` | | | arguments to this function are incorrect | note: associated function defined here --> /Users/alamb/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/convert/mod.rs:548:8 | 548 | fn from(value: T) -> Self; | ^^^^ error[E0308]: mismatched types --> datafusion/common/src/dfschema.rs:743:73 | 743 | DFSchema::from(self).equivalent_names_and_types(&DFSchema::from(other)) | -------------- ^^^^^ expected `DFSchema`, found `&Schema` | | | arguments to this function are incorrect | note: associated function defined here --> /Users/alamb/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/convert/mod.rs:548:8 | 548 | fn from(value: T) -> Self; | ^^^^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
