js8544 commented on code in PR #35787:
URL: https://github.com/apache/arrow/pull/35787#discussion_r1245364297
##########
cpp/src/arrow/compute/kernel.h:
##########
@@ -293,6 +298,10 @@ class ARROW_EXPORT OutputType {
OutputType(Resolver resolver) // NOLINT implicit construction
: kind_(COMPUTED), resolver_(std::move(resolver)) {}
+ /// \brief For backward compatibility
+ OutputType(ResolverFuncPtr resolver) // NOLINT implicit construction
+ : kind_(COMPUTED), resolver_(std::move(resolver)) {}
Review Comment:
Since the constructors are not marked explicit, many existing codes
implicitly pass a function pointer as `OutputType`. To make them compile, I'll
have to either add this constructor or change all occurences. I chose the
easier path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
