[GitHub] [arrow] js8544 commented on a diff in pull request #35787: GH-35786: [C++] Add pairwise_diff function

[via GitHub]

js8544 commented on code in PR #35787:
URL: https://github.com/apache/arrow/pull/35787#discussion_r1245431774


##########
cpp/src/arrow/compute/kernel.h:
##########
@@ -293,6 +298,10 @@ class ARROW_EXPORT OutputType {
   OutputType(Resolver resolver)  // NOLINT implicit construction
       : kind_(COMPUTED), resolver_(std::move(resolver)) {}
 
+  /// \brief For backward compatibility
+  OutputType(ResolverFuncPtr resolver)  // NOLINT implicit construction
+      : kind_(COMPUTED), resolver_(std::move(resolver)) {}

Review Comment:
   Actually making this a templated method is more elegant. Problem solved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org