yyang52 commented on code in PR #35886:
URL: https://github.com/apache/arrow/pull/35886#discussion_r1246206155
##########
cpp/src/arrow/util/compression.h:
##########
@@ -107,6 +107,50 @@ class ARROW_EXPORT Decompressor {
// XXX add methods for buffer size heuristics?
};
+/// \brief Compression codec options
+class ARROW_EXPORT CodecOptions {
+ public:
+ CodecOptions(int compression_level = kUseDefaultCompressionLevel) {
+ compression_level_ = compression_level;
+ }
+ virtual ~CodecOptions() = default;
+
+ int compression_level_;
+};
Review Comment:
It gives me the compilation error:
```
error: no matching constructor for initialization of
'arrow::util::CodecOptions'
return Codec::Create(codec_type, CodecOptions{compression_level});
^ ~~~~~~~~~~~~~~~~~~~
/home/yangyang/arrow/cpp/src/arrow/util/compression.h:111:20: note:
candidate constructor (the implicit copy constructor) not viable: no known
conversion from 'int' to 'const arrow::util::CodecOptions' for 1st argument
class ARROW_EXPORT CodecOptions {
^
/home/yangyang/arrow/cpp/src/arrow/util/compression.h:111:20: note:
candidate constructor (the implicit default constructor) not viable: requires 0
arguments, but 1 was provided
1 error generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
