yyang52 commented on code in PR #35886:
URL: https://github.com/apache/arrow/pull/35886#discussion_r1247484665
##########
cpp/src/arrow/util/compression.h:
##########
@@ -107,6 +107,44 @@ class ARROW_EXPORT Decompressor {
// XXX add methods for buffer size heuristics?
};
+/// \brief Compression codec options
+class ARROW_EXPORT CodecOptions {
+ public:
+ explicit CodecOptions(int compression_level = kUseDefaultCompressionLevel) {
+ compression_level_ = compression_level;
+ }
+ virtual ~CodecOptions() = default;
+
+ int compression_level_;
Review Comment:
yeah I made some changes to these part, will push those soon.
##########
cpp/src/parquet/platform.h:
##########
@@ -24,7 +24,8 @@
#include "arrow/io/interfaces.h" // IWYU pragma: export
#include "arrow/status.h" // IWYU pragma: export
#include "arrow/type_fwd.h" // IWYU pragma: export
-#include "arrow/util/macros.h" // IWYU pragma: export
+#include "arrow/util/compression.h"
Review Comment:
yes, could I include that directly in `column_writer.h`, as the forward
declaration is not sufficient to initialize an object as far as I learned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
