zeroshade commented on code in PR #36365:
URL: https://github.com/apache/arrow/pull/36365#discussion_r1246859678
##########
go/arrow/schema.go:
##########
@@ -194,12 +194,13 @@ func (sc *Schema) WithEndianness(e endian.Endianness)
*Schema {
func (sc *Schema) Endianness() endian.Endianness { return sc.endianness }
func (sc *Schema) IsNativeEndian() bool { return sc.endianness ==
endian.NativeEndian }
func (sc *Schema) Metadata() Metadata { return sc.meta }
-func (sc *Schema) Fields() []Field {
+func (sc *Schema) Fields() []Field {
fields := make([]Field, len(sc.fields))
copy(fields, sc.fields)
return fields
}
-func (sc *Schema) Field(i int) Field { return sc.fields[i] }
+func (sc *Schema) Field(i int) Field { return sc.fields[i] }
+func (sc *Schema) NumFields() int { return len(sc.fields) }
Review Comment:
Can you add a small unit test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
