abetomo commented on code in PR #36373:
URL: https://github.com/apache/arrow/pull/36373#discussion_r1247335358
##########
.github/workflows/js.yml:
##########
@@ -90,6 +90,14 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
+ - name: Jest Cache
+ uses: actions/cache@v3
+ with:
+ path: js/.jest-cache
+ key: js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('js/yarn.lock') }}
+ restore-keys: |
+ js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-
+ js-jest-cache-${{ runner.os }}-
Review Comment:
Will you be testing on more than one `node` in the future?
(like `node: [18, 20]`.)
I just tested a few times locally and it seemed a little faster to use the
cache of the same Node.js version.
It is certainly unnecessary if you don't test with multiple `node`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
