kou commented on code in PR #36373:
URL: https://github.com/apache/arrow/pull/36373#discussion_r1247339129
##########
.github/workflows/js.yml:
##########
@@ -90,6 +90,14 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
+ - name: Jest Cache
+ uses: actions/cache@v3
+ with:
+ path: js/.jest-cache
+ key: js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('js/yarn.lock') }}
+ restore-keys: |
+ js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-
+ js-jest-cache-${{ runner.os }}-
Review Comment:
We'll not use multiple Node.js versions unless we reduce CI time. (40+
minutes is too long to run multiple jobs. If we want to test against multiple
Node.js versions, we'll use nightly CI that are defined in
`dev/tasks/tasks.yml`.)
If the difference between with/without `-${{ matrix.node }}`, we want to
unify it to reduce cache size. apache/arrow has multiple language
implementations. So cache limit provided by GitHub Actions is small for us. So
we want to reduce cache size as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
