tustvold commented on code in PR #4470:
URL: https://github.com/apache/arrow-rs/pull/4470#discussion_r1247914559
##########
arrow-row/src/lib.rs:
##########
@@ -832,14 +874,25 @@ struct RowConfig {
#[derive(Debug)]
pub struct Rows {
/// Underlying row bytes
- buffer: Box<[u8]>,
+ buffer: Vec<u8>,
/// Row `i` has data `&buffer[offsets[i]..offsets[i+1]]`
- offsets: Box<[usize]>,
+ offsets: Vec<usize>,
/// The config for these rows
config: RowConfig,
}
impl Rows {
+ /// Append a [`Row`] to this [`Rows`]
+ pub fn push(&mut self, row: Row<'_>) {
+ assert!(
+ Arc::ptr_eq(&row.config.fields, &self.config.fields),
+ "row was not produced by this RowConverter"
+ );
+ self.config.validate_utf8 |= row.config.validate_utf8;
Review Comment:
This is consistent with the logic elsewhere, and is ultimately harmless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
