tustvold commented on code in PR #4470:
URL: https://github.com/apache/arrow-rs/pull/4470#discussion_r1247916308
##########
arrow-row/src/lib.rs:
##########
@@ -756,6 +756,48 @@ impl RowConverter {
unsafe { self.convert_raw(&mut rows, validate_utf8) }
}
+ /// Returns an empty [`Rows`] with capacity for `row_capacity` rows with
+ /// a total length of `data_capacity`
+ ///
+ /// This can be used to buffer a selection of [`Row`]
+ ///
+ /// ```
+ /// # use std::sync::Arc;
+ /// # use std::collections::HashSet;
+ /// # use arrow_array::cast::AsArray;
+ /// # use arrow_array::StringArray;
+ /// # use arrow_row::{Row, RowConverter, SortField};
+ /// # use arrow_schema::DataType;
+ /// #
+ /// let mut converter =
RowConverter::new(vec![SortField::new(DataType::Utf8)]).unwrap();
Review Comment:
This is already stated just above the code block, the commented out imports
just make it hard to see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
