alamb commented on PR #6800:
URL:
https://github.com/apache/arrow-datafusion/pull/6800#issuecomment-1620409390
Ok, so this PR now passes a significant amount of the aggregate tests 🎉
```shell
cargo test --test sqllogictests -- aggregate
```
The current diff is here:
```
[SQL] SELECT c1, SUM(c2) FILTER (WHERE c2 >= 20) as result FROM test_table
GROUP BY c1
[Diff] (-expected|+actual)
1 20
2 20
- 3 NULL
+ 3 0
```
Which I understand (filtering with NULLs need to be handled slightly
differently). I'll try and work on a fix / improvement shortly.
cc @Dandandan I recommend you hold off on implementing any additional
accumulators until I have sorted this one out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
