alamb commented on PR #6800: URL: https://github.com/apache/arrow-datafusion/pull/6800#issuecomment-1620845529
> 👍 Feel free to overwrite any changes, my solution is similar to one previously, but actually could be made more efficient by properly keeping/combining bitmaps instead of counts. Thanks @Dandandan -- I pushed https://github.com/apache/arrow-datafusion/pull/6800/commits/ad6d4f31e7bc2c1fb936c0b5da308bf6d5b9979a which I think implements what you refer to of keeping / combining bitmaps. `cargo test --test sqllogictests -- aggregate` now passes on this branch 🎉 I am actually quite please that I was able to handle the nulls / filtering in a new struct `NullState` which then lets the individual accumulators become quite simple (mostly) Tomorrow I'll try and remove `accumulate_all` and update count. 👋 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
