mapleFU commented on code in PR #36431:
URL: https://github.com/apache/arrow/pull/36431#discussion_r1252266675
##########
cpp/src/arrow/array/util.cc:
##########
@@ -77,7 +77,9 @@ class ArrayDataWrapper {
class ArrayDataEndianSwapper {
public:
- explicit ArrayDataEndianSwapper(const std::shared_ptr<ArrayData>& data) :
data_(data) {
+ explicit ArrayDataEndianSwapper(const std::shared_ptr<ArrayData>& data,
+ MemoryPool* pool)
+ : data_(data), pool_(pool) {
Review Comment:
Quick answer: yes, `ArrayDataEndianSwapper` is merly used. I've capture all
callings.
And `pool_` haven't been default initialized. So compiler will prevent from
that calling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
