mapleFU commented on code in PR #36431:
URL: https://github.com/apache/arrow/pull/36431#discussion_r1252269234
##########
cpp/src/arrow/array/util.cc:
##########
@@ -77,7 +77,9 @@ class ArrayDataWrapper {
class ArrayDataEndianSwapper {
public:
- explicit ArrayDataEndianSwapper(const std::shared_ptr<ArrayData>& data) :
data_(data) {
+ explicit ArrayDataEndianSwapper(const std::shared_ptr<ArrayData>& data,
+ MemoryPool* pool)
+ : data_(data), pool_(pool) {
Review Comment:
1. class `ArrayDataEndianSwapper` has prevent from it, and doesn't have
default argument
2. function `SwapEndianArrayData` has default argument. It's only used in
`ipc`, and I've changed them. You can check it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
