tustvold commented on PR #4465: URL: https://github.com/apache/arrow-rs/pull/4465#issuecomment-1622774487
> how well covered is this code The existing tests of the dyn kernels which now call into this logic should give fairly good coverage, definitely could be improved though. Happy to do as a follow on > add_wrapping This was an attempt to encourage the checked logic by default, I can change it back if you feel strongly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
