tustvold commented on code in PR #4465:
URL: https://github.com/apache/arrow-rs/pull/4465#discussion_r1253815484
##########
arrow-arith/src/aggregate.rs:
##########
@@ -897,54 +897,35 @@ mod tests {
#[test]
fn test_primitive_array_sum_large_64() {
- let a: Int64Array = (1..=100)
- .map(|i| if i % 3 == 0 { Some(i) } else { None })
- .collect();
- let b: Int64Array = (1..=100)
- .map(|i| if i % 3 == 0 { Some(0) } else { Some(i) })
- .collect();
// create an array that actually has non-zero values at the invalid
indices
- let c = add(&a, &b).unwrap();
+ let validity = NullBuffer::new((1..=100).map(|x| x % 3 ==
0).collect());
Review Comment:
It was to avoid using a now deprecated kernel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
