mingmwang commented on PR #6800: URL: https://github.com/apache/arrow-datafusion/pull/6800#issuecomment-1622933152
> e the bounds check (and use `unsafe` for the access to `self.counts` an > I brought down the difference for query 1 to only ~1.05x (slower) (by moving the updates into one loop). > > I think we should be able to do the same for `merge_batch` with some additional code, not sure if it's worth the additional complexity ATM. I think it is acceptable for the slowness of q1. I believe we can get the performance back in the following PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
