alamb commented on PR #6800: URL: https://github.com/apache/arrow-datafusion/pull/6800#issuecomment-1623405401
> @alamb what are your plans going forward? Do we need to implement all the specialized accumulators first? Maybe we are good enough to clean this up, merge it and handle the other accumulators in other tickets/PRs? My original plan had been to do the cleanups prior to merging, but I would also be fine with doing the cleanup on master. I feel quite strongly about removing the RowAccumulators (which will require removing the duplication between this code and the streaming group by as well as implementing the remaining row accumulators) However, I agree it could be done directly on master. How about this for a proposed plan: 1. We polish this PR up (maybe we can create a new PR with the same code to make reviews easier) 2. We file a follow on ticket with the remaining items todo 3. We work to clean up the remaining pieces afterwards? Today I will spend some time getting the remaining tests to pass and re-reviewing the code that is already present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
