rtpsw opened a new pull request, #36499:
URL: https://github.com/apache/arrow/pull/36499

   ### What changes are included in this PR?
   
   The key hasher is invalidated before the first invocation of `GetKey` (via 
`GetLatestKey`) after a new batch arrives. In the pre-PR code, this 
invalidation happens within `Advance`, which is called from `AdvanceAndMemoize` 
only after `GetLatestKey` is called. The change adds synchronization between 
the input-receiving- and processing- threads, because avoiding that would 
require a more complicated and brittle change, e.g., one that involves 
detecting in the processing thread when a new batch was added to the queue in 
order to invalidate the key hasher at that time.
   
   ### Are these changes tested?
   
   Yes, by existing tests.
   
   ### Are there any user-facing changes?
   
   No.
   
   **This PR contains a "Critical Fix".**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to