pitrou commented on PR #36499: URL: https://github.com/apache/arrow/pull/36499#issuecomment-1623653653
I also don't understand why you call `Invalidate` explicitly, while the `KeyHasher` is supposed to invalidate automatically. However, I see that `KeyHasher` is storing a raw `RecordBatch` pointer, which is problematic. If the previous `std::shared_ptr<RecordBatch>` was destroyed, another `std::shared_ptr<RecordBatch>` could re-allocate the same underlying `RecordBatch` pointer, which is unlikely but not impossible. Am I missing something here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
