pitrou commented on code in PR #36424:
URL: https://github.com/apache/arrow/pull/36424#discussion_r1254386983
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -461,6 +461,29 @@ TEST(Expression, IsSatisfiable) {
// fill_na)
EXPECT_TRUE(Bind(call("is_null", {never_true})).IsSatisfiable());
}
+
+ for (const auto& might_true : {
+ // N.B. this is "or_kleene"
+ or_(literal(false), field_ref("bool")),
+ or_(literal(null), field_ref("bool")),
+ call("or", {literal(false), field_ref("bool")}),
+ call("or", {literal(null), field_ref("bool")}),
+ }) {
+ ARROW_SCOPED_TRACE(might_true.ToString());
+ EXPECT_TRUE(Bind(might_true).IsSatisfiable());
+ }
+
+ for (const auto& never_true : {
+ // N.B. this is "or_kleene"
+ or_(literal(false), literal(null)),
+ call("or", {literal(false), literal(null)}),
Review Comment:
Doesn't this test simply exercise constant folding? @bkietz What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
