pitrou commented on code in PR #36424:
URL: https://github.com/apache/arrow/pull/36424#discussion_r1254480060
##########
cpp/src/arrow/compute/expression.h:
##########
@@ -94,7 +94,11 @@ class ARROW_EXPORT Expression {
bool IsNullLiteral() const;
/// Return true if this expression could evaluate to true. Will return true
for any
- /// unbound, non-boolean, or unsimplified Expressions
+ /// unbound or non-boolean Expressions. IsSatisfiable does not (currently)
do any
+ /// canonicalization or simplification of the expression, so even Expressions
+ /// which are be unsatisfiable may spuriously return `true` here. This
function is
Review Comment:
Typo
```suggestion
/// which are unsatisfiable may spuriously return `true` here. This
function is
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
