pitrou commented on code in PR #35886:
URL: https://github.com/apache/arrow/pull/35886#discussion_r1229796770
##########
cpp/src/parquet/properties_test.cc:
##########
@@ -70,6 +70,37 @@ TEST(TestWriterProperties, AdvancedHandling) {
ASSERT_EQ(ParquetDataPageVersion::V2, props->data_page_version());
}
+TEST(TestWriterProperties, SetCodecOptions) {
+ WriterProperties::Builder builder;
+ builder.compression("gzip", Compression::GZIP);
+ builder.compression("zstd", Compression::ZSTD);
+ builder.compression("brotli", Compression::BROTLI);
+ auto gzip_codec_options =
std::make_shared<::arrow::util::GZipCodecOptions>();
+ gzip_codec_options->compression_level_ = 9;
+ gzip_codec_options->window_bits = 12;
+ builder.codec_options("gzip", gzip_codec_options);
+ auto codec_options = std::make_shared<CodecOptions>();
+ builder.codec_options(codec_options);
+ auto brotli_codec_options =
std::make_shared<::arrow::util::BrotliCodecOptions>();
+ brotli_codec_options->compression_level_ = 11;
+ brotli_codec_options->window_bits = 20;
+ builder.codec_options("brotli", brotli_codec_options);
+ std::shared_ptr<WriterProperties> props = builder.build();
+
+ ASSERT_EQ(9,
+
props->codec_options(ColumnPath::FromDotString("gzip"))->compression_level_);
+ ASSERT_EQ(12, std::dynamic_pointer_cast<::arrow::util::GZipCodecOptions>(
+ props->codec_options(ColumnPath::FromDotString("gzip")))
+ ->window_bits);
+ ASSERT_EQ(Codec::UseDefaultCompressionLevel(),
+
props->codec_options(ColumnPath::FromDotString("zstd"))->compression_level_);
Review Comment:
This is not very interesting as the default compression level would be used
in any case. Can you pass a non-default value for `codec_options` above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
