pitrou commented on code in PR #35886:
URL: https://github.com/apache/arrow/pull/35886#discussion_r1254522764


##########
cpp/src/arrow/util/compression.h:
##########
@@ -107,6 +108,40 @@ class ARROW_EXPORT Decompressor {
   // XXX add methods for buffer size heuristics?
 };
 
+/// \brief Compression codec options
+class ARROW_EXPORT CodecOptions {
+ public:
+  explicit CodecOptions(int compression_level = kUseDefaultCompressionLevel) {
+    compression_level_ = compression_level;
+  }
+  virtual ~CodecOptions() = default;
+
+  int compression_level_ = kUseDefaultCompressionLevel;

Review Comment:
   Forgot this, but style nit (this is a public member, it's weird to add a 
trailing underscore):
   ```suggestion
     int compression_level = kUseDefaultCompressionLevel;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to