westonpace commented on code in PR #36462:
URL: https://github.com/apache/arrow/pull/36462#discussion_r1254562403
##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -3740,6 +3761,10 @@ def test_dataset_preserved_partitioning(tempdir):
_, path = _create_single_file(tempdir)
dataset = ds.dataset(path)
assert isinstance(dataset.partitioning, ds.DirectoryPartitioning)
+ # TODO partitioning attribute not preserved in pickling
Review Comment:
```suggestion
# TODO(GH-34884) partitioning attribute not preserved in pickling
```
##########
python/pyarrow/includes/libarrow_dataset.pxd:
##########
@@ -288,13 +288,14 @@ cdef extern from "arrow/dataset/api.h" namespace
"arrow::dataset" nogil:
c_string type_name() const
CResult[CExpression] Parse(const c_string & path) const
const shared_ptr[CSchema] & schema()
+ c_bool Equals(const CPartitioning& other) const
cdef cppclass CSegmentEncoding" arrow::dataset::SegmentEncoding":
- pass
+ bint operator==(CSegmentEncoding)
Review Comment:
Just for my own curiosity, is `bint` different than `c_bool`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
