icexelloss commented on code in PR #36499:
URL: https://github.com/apache/arrow/pull/36499#discussion_r1255830133
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -524,7 +524,7 @@ class KeyHasher {
size_t index_;
std::vector<col_index_t> indices_;
std::vector<KeyColumnMetadata> metadata_;
- const RecordBatch* batch_;
+ std::atomic<const RecordBatch*> batch_;
Review Comment:
Is the KeyHasher class thread safe now? Since with this change there are two
thread using this class, we should clearly document what the thread safety
model of this class is. (What happens if the hash is invalidated in the middle
of processing?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
