felipecrv commented on code in PR #36521:
URL: https://github.com/apache/arrow/pull/36521#discussion_r1256731168


##########
cpp/src/arrow/util/byte_size.cc:
##########
@@ -294,6 +295,21 @@ struct GetByteRangesArray {
     return Status::OK();
   }
 
+  Status Visit(const RunEndEncodedType& type) const {
+    auto [phys_offset, phys_length] = ree_util::FindPhysicalRange(input, 
offset, length);
+    for (int i = 0; i < type.num_fields(); i++) {
+      GetByteRangesArray child{
+          *input.child_data[i],
+          /*offset=*/input.child_data[i]->offset + phys_offset,
+          /*length=*/phys_length,
+          range_starts,
+          range_offsets,
+          range_lengths};

Review Comment:
   ```suggestion
         GetByteRangesArray child{
             *input.child_data[i],
             /*offset=*/input.child_data[i]->offset + phys_offset,
             /*length=*/phys_length,
             range_starts,
             range_offsets,
             range_lengths};
   ```
   ```suggestion
         GetByteRangesArray child{*input.child_data[i],
                                  /*offset=*/input.child_data[i]->offset + 
phys_offset,
                                  /*length=*/phys_length,
                                  range_starts,
                                  range_offsets,
                                  range_lengths};
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to