pitrou commented on code in PR #36521: URL: https://github.com/apache/arrow/pull/36521#discussion_r1259744689
########## cpp/src/arrow/util/ree_util.h: ########## @@ -138,6 +152,13 @@ int64_t FindPhysicalIndex(const ArraySpan& span, int64_t i, int64_t absolute_off /// end). This function uses binary-search, so it has a O(log N) cost. int64_t FindPhysicalLength(const ArraySpan& span); +/// \brief Find the physical range of physical values referenced by the REE in +/// the logical range from offset to offset + length +/// +/// \return a pair of physical offset and physical length +std::pair<int64_t, int64_t> FindPhysicalRange(const ArraySpan& span, int64_t offset, Review Comment: You need to ARROW_EXPORT this as well as the non-template `FindPhysicalIndex` and `FindPhysicalLength`, for Windows. ########## cpp/src/arrow/util/ree_util.h: ########## @@ -138,6 +152,13 @@ int64_t FindPhysicalIndex(const ArraySpan& span, int64_t i, int64_t absolute_off /// end). This function uses binary-search, so it has a O(log N) cost. int64_t FindPhysicalLength(const ArraySpan& span); +/// \brief Find the physical range of physical values referenced by the REE in +/// the logical range from offset to offset + length +/// +/// \return a pair of physical offset and physical length +std::pair<int64_t, int64_t> FindPhysicalRange(const ArraySpan& span, int64_t offset, Review Comment: You need to ARROW_EXPORT this as well as the non-template `FindPhysicalIndex` and `FindPhysicalLength`, for Windows (see CI failures). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
