kou commented on code in PR #36434: URL: https://github.com/apache/arrow/pull/36434#discussion_r1257430393
########## cpp/src/arrow/vendored/fast_float/parse_number.h: ########## @@ -1,5 +1,6 @@ #ifndef FASTFLOAT_PARSE_NUMBER_H #define FASTFLOAT_PARSE_NUMBER_H +#define FASTFLOAT_ALLOWS_LEADING_PLUS 1 Review Comment: Could you define this in `cpp/src/arrow/util/value_parsing.cc` instead of here? If we define this here, this change will be discarded when we update fast_float next time. And could you also add a Gandiva test to check `+Infinity` is accepted or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
