kou commented on code in PR #36434: URL: https://github.com/apache/arrow/pull/36434#discussion_r1264640695
########## cpp/src/arrow/util/value_parsing.cc: ########## @@ -14,6 +14,8 @@ // KIND, either express or implied. See the License for the // specific language governing permissions and limitations // under the License. +#ifndef FASTFLOAT_ALLOWS_LEADING_PLUS Review Comment: Why do we need this `ifndef`? What situation are you thinking? I think that this is needless... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
