tustvold commented on code in PR #4502:
URL: https://github.com/apache/arrow-rs/pull/4502#discussion_r1258343480
##########
object_store/src/lib.rs:
##########
@@ -527,7 +527,10 @@ pub trait ObjectStore: std::fmt::Display + Send + Sync +
Debug + 'static {
}
#[async_trait]
-impl ObjectStore for Box<dyn ObjectStore> {
+impl<T> ObjectStore for T
Review Comment:
What do you think of using a macro instead of a generic. As Rust lacks
specialization support blanket implementations such as this have an annoying
habit of causing annoying conflicts down the line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
