tustvold commented on code in PR #4502:
URL: https://github.com/apache/arrow-rs/pull/4502#discussion_r1258348153


##########
object_store/src/lib.rs:
##########
@@ -527,7 +527,10 @@ pub trait ObjectStore: std::fmt::Display + Send + Sync + 
Debug + 'static {
 }
 
 #[async_trait]
-impl ObjectStore for Box<dyn ObjectStore> {
+impl<T> ObjectStore for T

Review Comment:
   I think I would prefer the macro approach, less chance of unintended 
consequences



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to