alamb commented on a change in pull request #8930:
URL: https://github.com/apache/arrow/pull/8930#discussion_r546676327
##########
File path: rust/datafusion/src/logical_plan/plan.rs
##########
@@ -561,6 +561,7 @@ impl From<&PlanType> for String {
/// Represents some sort of execution plan, in String form
#[derive(Debug, Clone, PartialEq)]
+#[allow(clippy::rc_buffer)]
Review comment:
@Dandandan -- It did give alternatives but I did not figure out how to
apply it.
The actually clippy lint didn't make a whole lot of sense to me as it seems
to be focused on the mutability of the Arc/Rc's elements, which doesn't seem to
apply here. From my reading of this code and the other callsites, the use case
of using `Arc<String>` is not *mutability* of the contained `String` but rather
cheaply copying it around.
Using `Arc<str>` doesn't make sense as the actual String is allocated at
runtime (it is the formatted version of an explain plan)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
