Dandandan commented on a change in pull request #8930:
URL: https://github.com/apache/arrow/pull/8930#discussion_r546763735
##########
File path: rust/datafusion/src/logical_plan/plan.rs
##########
@@ -561,6 +561,7 @@ impl From<&PlanType> for String {
/// Represents some sort of execution plan, in String form
#[derive(Debug, Clone, PartialEq)]
+#[allow(clippy::rc_buffer)]
Review comment:
There is some discussion about why it can make sense to use `Arc<str>`
over `Arc<String>`:
https://users.rust-lang.org/t/arc-string-vs-arc-str/30571
of course, difference is minimal, only saving a bit of indirection/some
bytes.
You can use `into` to convert a `String` or `&str` into a `Arc<str>` or
`Rc<str>`
https://doc.rust-lang.org/std/sync/struct.Arc.html#impl-From%3CString%3E
Example:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb6db938ae03b001edca59aba1512d33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
