pitrou commented on code in PR #36418:
URL: https://github.com/apache/arrow/pull/36418#discussion_r1259805891
##########
cpp/src/arrow/buffer.h:
##########
@@ -137,6 +140,25 @@ class ARROW_EXPORT Buffer {
/// \return a new Buffer instance
static std::shared_ptr<Buffer> FromString(std::string data);
+ /// \brief Construct an immutable buffer that takes ownership of the contents
+ /// of an std::vector (without copying it).
+ ///
+ /// \param[in] vec a vector to own
+ /// \return a new Buffer instance
+ template <typename T>
+ static std::shared_ptr<Buffer> FromVectorOfTrivial(std::vector<T> vec) {
+ static_assert(std::is_trivial_v<T>);
Review Comment:
Instead of the wacky name, why not make the compile error more explicit?
```suggestion
static std::shared_ptr<Buffer> FromVector(std::vector<T> vec) {
static_assert(std::is_trivial_v<T>, "Buffer::FromVector needs a trivial
type");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
