mustafasrepo commented on code in PR #6956:
URL: https://github.com/apache/arrow-datafusion/pull/6956#discussion_r1264963749
##########
datafusion/core/src/physical_plan/coalesce_partitions.rs:
##########
@@ -107,6 +107,10 @@ impl ExecutionPlan for CoalescePartitionsExec {
self.input.equivalence_properties()
}
+ fn ordering_equivalence_properties(&self) -> OrderingEquivalenceProperties
{
Review Comment:
Actually, when existing ordering is invalidated (`maintains_input_order` is
false). `OrderingEquivalenceProperties` shouldn't be propagated (unlike
`Equivalence`). The reason is that `OrderingEquivalence` contains different
alternative versions to describe ordering of the table. Once ordering is lost,
all of the alternatives descriptions are invalid also. Hence this
implementation should be removed. I removed this implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
