mustafasrepo commented on code in PR #6956:
URL: https://github.com/apache/arrow-datafusion/pull/6956#discussion_r1264970204
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -381,6 +376,34 @@ impl ExecutionPlan for HashJoinExec {
)
}
+ fn ordering_equivalence_properties(&self) -> OrderingEquivalenceProperties
{
Review Comment:
Similar to above reasoning, only `HashJoinExec` maintains_input_order under
certain conditions. Hence, the only join that needs ordering_equivalence
implementation is `HashJoinExec`. However, other joins such as `CrossJoin`,
`NestedLoopsJoin ` may maintain ordering under certain conditions if so
ordering equivalence can be implemented for them also. I will analyze their
implementation, if there are case that ordering can be maintained, I will
implement their `maintains_input_order` and `ordering_equivalence_properties`
methods in follow-up PRs. During that PR we can move, this implementation to a
common location if there is a pattern between `ordering_equivalence_properties`
of different joins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
