WillAyd commented on code in PR #258:
URL: https://github.com/apache/arrow-nanoarrow/pull/258#discussion_r1265863431
##########
src/nanoarrow/nanoarrow_types.h:
##########
@@ -656,6 +672,19 @@ struct ArrowArrayPrivateData {
int8_t union_type_id_is_child_index;
};
+/// \brief A representation of an interval.
+struct ArrowInterval {
+ /// \brief The type of interval being used
+ enum ArrowIntervalUnit unit;
+
+ /// \brief Pointer containing the underlying data for the interval
+ union {
+ int32_t year_month;
+ struct ArrowIntervalDayTime day_time;
+ struct ArrowIntervalMonthDayNano month_day_nano;
+ } data;
+};
Review Comment:
`time` is supposed to represent milliseconds in that struct right? Not a
strong preference but I think using the structs is a little easier as an end
user. With the current design I was thinking an anonymous union would be the
best, though that would require C11 instead of just C99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
