paleolimbot commented on code in PR #258:
URL: https://github.com/apache/arrow-nanoarrow/pull/258#discussion_r1267106789
##########
src/nanoarrow/nanoarrow_types.h:
##########
@@ -656,6 +672,19 @@ struct ArrowArrayPrivateData {
int8_t union_type_id_is_child_index;
};
+/// \brief A representation of an interval.
+struct ArrowInterval {
+ /// \brief The type of interval being used
+ enum ArrowIntervalUnit unit;
+
+ /// \brief Pointer containing the underlying data for the interval
+ union {
+ int32_t year_month;
+ struct ArrowIntervalDayTime day_time;
+ struct ArrowIntervalMonthDayNano month_day_nano;
+ } data;
+};
Review Comment:
I suppose we still need something to `memcpy()` into though...I'm much more
interested in having interval support than having the struct be exactly like
`ArrowDecimal` (although `ArrowIntervalUnit` can probably just be `ArrowType`
unless there's another distinction I'm missing?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
