pitrou opened a new pull request, #36769:
URL: https://github.com/apache/arrow/pull/36769

   ### Rationale for this change
   
   Our nightly build on i386 Debian (a 32-bit x86 build) fails with an error in 
decimal-to-read tests:
   
https://github.com/ursacomputing/crossbow/actions/runs/5593823296/jobs/10227952675#step:6:3255
   
   ### What changes are included in this PR?
   
   Improve error messages by displaying the actual and expected values.
   
   A side effect of this error message improvement is to... fix the test 
failure, as storing the computation result in a local variable seems to change 
the computed absolute difference.
   
   This is probably due to x86 FPU rounding shenanigans, as explained here: 
https://stackoverflow.com/questions/37626687/c-fundamentals-double-variable-not-equal-to-double-expression
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to