js8544 commented on code in PR #36769:
URL: https://github.com/apache/arrow/pull/36769#discussion_r1267774111
##########
cpp/src/arrow/util/decimal_test.cc:
##########
@@ -1046,42 +1046,51 @@ using ToDoubleTestParam = ToRealTestParam<double>;
template <typename Decimal, typename Real>
void CheckDecimalToReal(const std::string& decimal_value, int32_t scale, Real
expected) {
Decimal dec(decimal_value);
- ASSERT_EQ(dec.template ToReal<Real>(scale), expected)
- << "Decimal value: " << decimal_value << " Scale: " << scale;
+ Real actual = dec.template ToReal<Real>(scale);
+ ASSERT_EQ(actual, expected) << "Decimal value: " << decimal_value
+ << ", scale: " << scale << ", expected: " <<
expected
+ << ", actual: " << actual;
}
template <typename Decimal, typename Real>
void CheckDecimalToRealWithinOneULP(const std::string& decimal_value, int32_t
scale,
Real expected) {
Decimal dec(decimal_value);
- auto result = dec.template ToReal<Real>(scale);
- ASSERT_TRUE(result == expected || result == std::nextafter(expected,
expected + 1) ||
- result == std::nextafter(expected, expected - 1))
- << "Decimal value: " << decimal_value << " Scale: " << scale;
+ Real actual = dec.template ToReal<Real>(scale);
+ ASSERT_TRUE(actual == expected || actual == std::nextafter(expected,
expected + 1) ||
+ actual == std::nextafter(expected, expected - 1))
+ << "Decimal value: " << decimal_value << ", scale: " << scale
+ << ", expected: " << expected << ", actual: " << actual;
}
template <typename Decimal, typename Real>
void CheckDecimalToRealWithinEpsilon(const std::string& decimal_value, int32_t
scale,
Real epsilon, Real expected) {
Decimal dec(decimal_value);
- ASSERT_TRUE(std::abs(dec.template ToReal<Real>(scale) - expected) <= epsilon)
- << "Decimal value: " << decimal_value << " Scale: " << scale;
+ Real actual = dec.template ToReal<Real>(scale);
+ ASSERT_TRUE(std::abs(actual - expected) <= epsilon)
Review Comment:
Maybe change it to ASSERT_LE(std::abs(actual - expected), epsilon) for an
"even better" message?
```suggestion
ASSERT_LE(std::abs(actual - expected), epsilon)
```
##########
cpp/src/arrow/util/decimal_test.cc:
##########
@@ -1046,42 +1046,51 @@ using ToDoubleTestParam = ToRealTestParam<double>;
template <typename Decimal, typename Real>
void CheckDecimalToReal(const std::string& decimal_value, int32_t scale, Real
expected) {
Decimal dec(decimal_value);
- ASSERT_EQ(dec.template ToReal<Real>(scale), expected)
- << "Decimal value: " << decimal_value << " Scale: " << scale;
+ Real actual = dec.template ToReal<Real>(scale);
Review Comment:
I'm curious: is it possible to set the precision for gtest outputs like
`std::setprecision`. The default precision won't be very helpful for small
diffs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
