lidavidm commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1268407342
########## cpp/src/arrow/flight/sql/protocol_internal.h: ########## @@ -24,3 +24,4 @@ #include "arrow/flight/sql/visibility.h" #include "arrow/flight/sql/FlightSql.pb.h" // IWYU pragma: export +#include "arrow/flight/Flight.pb.h" Review Comment: Sorry, I missed this; I think you won't be able to do this because of Protobuf linking complications. Instead, you'll have to define a C++ wrapper type that gets exported from libarrow_flight.dll, which gets used in libarrow_flight_sql.dll (i.e. Flight SQL won't be able to know/see that they're actually Protobufs underneath) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
