viirya commented on code in PR #7048:
URL: https://github.com/apache/arrow-datafusion/pull/7048#discussion_r1269990005
##########
datafusion/common/src/scalar.rs:
##########
@@ -1038,6 +1054,7 @@ macro_rules! impl_op_arithmetic {
get_sign!($OPERATION),
true,
)))),
+ // todo: Add Decimal256 support
Review Comment:
The error `DataFusion error: Internal error: Operator \+ is not implemented
for types Decimal256\(None,15,2\) and Decimal256\(Some\(12300\),15,2\)\.` from
running
```
create table t as values (arrow_cast(123, 'Decimal256(5,2)'));
select AVG(column1) from t;
```
in decimal.slt comes from lack of implementation of Decimal256 Scalar
arithmetic op.
It seems to be not easy to finish right now. So I left it as todo here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
