viirya commented on code in PR #7048: URL: https://github.com/apache/arrow-datafusion/pull/7048#discussion_r1269993962
########## datafusion/core/tests/sqllogictests/test_files/arrow_typeof.slt: ########## @@ -180,23 +180,29 @@ drop table foo statement ok create table foo as select - arrow_cast(100, 'Decimal128(5,2)') as col_d128 - -- Can't make a decimal 156: - -- This feature is not implemented: Can't create a scalar from array of type "Decimal256(3, 2)" - --arrow_cast(100, 'Decimal256(5,2)') as col_d256 + arrow_cast(100, 'Decimal128(5,2)') as col_d128, + arrow_cast(100, 'Decimal256(5,2)') as col_d256 ; ## Ensure each column in the table has the expected type -query T +query TT SELECT - arrow_typeof(col_d128) - -- arrow_typeof(col_d256), + arrow_typeof(col_d128), + arrow_typeof(col_d256) FROM foo; ---- -Decimal128(5, 2) +Decimal128(5, 2) Decimal256(5, 2) + +query RR +SELECT + col_d128, + col_d256 + FROM foo; +---- +100 100.00 Review Comment: Though, I'm not sure why displayed value for decimal256 shows decimal points but decimal128 doesn't. Needs to dig into where is the code for displaying it. But for now it seems minor to me. So just leave as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
