Jefffrey commented on code in PR #7063:
URL: https://github.com/apache/arrow-datafusion/pull/7063#discussion_r1272122810
##########
datafusion/core/src/dataframe.rs:
##########
@@ -1014,12 +1014,21 @@ impl DataFrame {
/// ```
pub fn with_column_renamed(
self,
- old_name: impl Into<Column>,
+ old_name: &str,
Review Comment:
Could be
```suggestion
old_name: impl Into<String>,
```
To maintain backwards compatibility technically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
