alamb commented on code in PR #7063:
URL: https://github.com/apache/arrow-datafusion/pull/7063#discussion_r1272683587
##########
datafusion/common/src/column.rs:
##########
@@ -97,9 +93,29 @@ impl Column {
),
// any expression that failed to parse or has more than 4 period
delimited
// identifiers will be treated as an unqualified column name
- _ => (None, flat_name),
+ _ => return None,
};
- Self { relation, name }
+ Some(Self { relation, name })
+ }
+
+ /// Deserialize a fully qualified name string into a column
Review Comment:
Maybe we can provide some examples in this doc like
```suggestion
/// Deserialize a fully qualified name string into a column
///
/// Treats the name as a SQL identifier. For example
/// `foo.BAR` would be parsed to a reference to relation `foo`, column
name `bar` (lower case)
/// where `"foo.BAR"` would be parsed to a reference to column named
`foo.BAR`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
