jackwener commented on code in PR #7081: URL: https://github.com/apache/arrow-datafusion/pull/7081#discussion_r1273074987
########## datafusion/core/tests/sqllogictests/test_files/subquery.slt: ########## @@ -846,65 +842,60 @@ query TT explain SELECT t1_id, (SELECT count(*) + 2 as cnt_plus_2 FROM t2 WHERE t2.t2_int = t1.t1_int having count(*) = 0) from t1 ---- logical_plan -Projection: t1.t1_id, CASE WHEN __scalar_sq_1.__always_true IS NULL THEN Int64(2) AS cnt_plus_2 WHEN __scalar_sq_1.COUNT(UInt8(1)) != Int64(0) THEN NULL ELSE __scalar_sq_1.cnt_plus_2 END AS cnt_plus_2 +Projection: t1.t1_id, __scalar_sq_1.cnt_plus_2 AS cnt_plus_2 --Left Join: t1.t1_int = __scalar_sq_1.t2_int ----TableScan: t1 projection=[t1_id, t1_int] ----SubqueryAlias: __scalar_sq_1 -------Projection: COUNT(UInt8(1)) + Int64(2) AS cnt_plus_2, t2.t2_int, COUNT(UInt8(1)), __always_true ---------Aggregate: groupBy=[[t2.t2_int, Boolean(true) AS __always_true]], aggr=[[COUNT(UInt8(1))]] -----------TableScan: t2 projection=[t2_int] +------Projection: COUNT(*) + Int64(2) AS cnt_plus_2, t2.t2_int +--------Filter: COUNT(*) = Int64(0) +----------Aggregate: groupBy=[[t2.t2_int]], aggr=[[COUNT(UInt8(1)) AS COUNT(*)]] +------------TableScan: t2 projection=[t2_int] Review Comment: cc @mingmwang I'm not sure whether new plan is right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
