alamb commented on code in PR #7081:
URL: https://github.com/apache/arrow-datafusion/pull/7081#discussion_r1278551262
##########
datafusion/core/tests/sqllogictests/test_files/subquery.slt:
##########
Review Comment:
The plans in this file look much better
##########
datafusion/optimizer/src/analyzer/count_wildcard_rule.rs:
##########
@@ -15,23 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+use crate::analyzer::AnalyzerRule;
use datafusion_common::config::ConfigOptions;
use datafusion_common::tree_node::{Transformed, TreeNode, TreeNodeRewriter};
-use datafusion_common::{Column, DFField, DFSchema, DFSchemaRef, Result};
-use datafusion_expr::expr::{AggregateFunction, Alias, InSubquery};
+use datafusion_common::Result;
+use datafusion_expr::expr::{AggregateFunction, InSubquery};
+use datafusion_expr::expr_rewriter::rewrite_preserving_name;
use datafusion_expr::utils::COUNT_STAR_EXPANSION;
use datafusion_expr::Expr::ScalarSubquery;
use datafusion_expr::{
- aggregate_function, count, expr, lit, window_function, Aggregate, Expr,
Filter,
- LogicalPlan, Projection, Sort, Subquery, Window,
+ aggregate_function, expr, lit, window_function, Aggregate, Expr, Filter,
LogicalPlan,
+ LogicalPlanBuilder, Projection, Sort, Subquery,
};
-use std::string::ToString;
use std::sync::Arc;
-use crate::analyzer::AnalyzerRule;
-
-pub const COUNT_STAR: &str = "COUNT(*)";
Review Comment:
🎉
##########
datafusion/optimizer/src/analyzer/count_wildcard_rule.rs:
##########
@@ -15,23 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+use crate::analyzer::AnalyzerRule;
use datafusion_common::config::ConfigOptions;
use datafusion_common::tree_node::{Transformed, TreeNode, TreeNodeRewriter};
-use datafusion_common::{Column, DFField, DFSchema, DFSchemaRef, Result};
-use datafusion_expr::expr::{AggregateFunction, Alias, InSubquery};
+use datafusion_common::Result;
+use datafusion_expr::expr::{AggregateFunction, InSubquery};
+use datafusion_expr::expr_rewriter::rewrite_preserving_name;
use datafusion_expr::utils::COUNT_STAR_EXPANSION;
use datafusion_expr::Expr::ScalarSubquery;
use datafusion_expr::{
- aggregate_function, count, expr, lit, window_function, Aggregate, Expr,
Filter,
- LogicalPlan, Projection, Sort, Subquery, Window,
+ aggregate_function, expr, lit, window_function, Aggregate, Expr, Filter,
LogicalPlan,
+ LogicalPlanBuilder, Projection, Sort, Subquery,
};
-use std::string::ToString;
use std::sync::Arc;
-use crate::analyzer::AnalyzerRule;
-
-pub const COUNT_STAR: &str = "COUNT(*)";
Review Comment:
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
