Fokko commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1274898844
##########
cpp/src/arrow/type_traits.h:
##########
@@ -1187,7 +1202,6 @@ constexpr bool is_var_length_list(Type::type type_id) {
switch (type_id) {
case Type::LIST:
case Type::LARGE_LIST:
- case Type::MAP:
Review Comment:
I was also reluctant to change this, but I think it is correct. This is in
line with the original PR:
https://github.com/apache/arrow/pull/12000/files#diff-d606ef26a35a58e56fc01c680ea87eaaba5488b63b71fb7ab37930f81ec159b8R980-R989
It is only used for internal methods AFAICT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
